ref: Update delete account messaging by nicholas-codecov · Pull Request #2892 · codecov/gazebo

nicholas-codecov · 2024-05-23T11:43:46Z

Description

Quick PR changing the messaging around personal account deletion.

Notable Changes

Remove account removal button
Update messaging to contact support for help with account deletion
Move to TS
Update tests

Screenshots

codecov-qa · 2024-05-23T11:47:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (2d764f5) to head (15c7708).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files         886      884       -2     
  Lines       13124    13096      -28     
  Branches     3511     3441      -70     
==========================================
- Hits        12922    12894      -28     
  Misses        198      198              
  Partials        4        4

Files	Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.22% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.01%)`	⬇️
Services	`99.48% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.73% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

codecov-notifications · 2024-05-23T11:47:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files         886      884       -2     
  Lines       13124    13096      -28     
  Branches     3506     3441      -65     
==========================================
- Hits        12922    12894      -28     
  Misses        198      198              
  Partials        4        4

Files	Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.22% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.01%)`	⬇️
Services	`99.48% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.73% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

codecov-public-qa · 2024-05-23T11:47:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (2d764f5) to head (15c7708).

✅ All tests successful. No failed tests found ☺️

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.01%     
==========================================
  Files         886      884       -2     
  Lines       13124    13096      -28     
  Branches     3506     3511       +5     
==========================================
- Hits        12922    12894      -28     
  Misses        198      198              
  Partials        4        4

Files	Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.22% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.01%)`	⬇️
Services	`99.48% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.73% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

codecov · 2024-05-23T11:48:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (2d764f5) to head (15c7708).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@               Coverage Diff                @@
##               main      #2892        +/-   ##
================================================
- Coverage   98.46000   98.45000   -0.01000     
================================================
  Files           886        884         -2     
  Lines         13124      13096        -28     
  Branches       3511       3487        -24     
================================================
- Hits          12922      12894        -28     
  Misses          198        198                
  Partials          4          4

Files	Coverage Δ
...tSettings/tabs/Admin/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
...ettings/tabs/Profile/DeletionCard/DeletionCard.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/tabs/Profile/Profile.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.22% <ø> (ø)`
Pages	`99.27% <100.00%> (-0.01%)`	⬇️
Services	`99.48% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.73% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d764f5...15c7708. Read the comment docs.

codecov-staging · 2024-05-23T11:49:17Z

Bundle Report

Changes will decrease total bundle size by 13.13kB ⬇️

Bundle name	Size	Change
gazebo-staging-array-push	6.93MB	13.13kB ⬇️

codecov · 2024-05-23T11:49:45Z

Bundle Report

Changes will decrease total bundle size by 13.13kB ⬇️

Bundle name	Size	Change
gazebo-production-array-push	6.93MB	13.13kB ⬇️

codecov-releaser · 2024-05-23T11:55:20Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`cd3024c`	Thu, 23 May 2024 11:55:20 GMT	Expired	Expired
`c16c0f6`	Tue, 28 May 2024 17:13:34 GMT	Expired	Expired
`aa75d9b`	Tue, 28 May 2024 17:33:49 GMT	Expired	Expired
`15c7708`	Mon, 03 Jun 2024 10:55:54 GMT	Cloud	Enterprise

rohitvinnakota-codecov · 2024-05-24T00:01:50Z

src/pages/AccountSettings/tabs/Admin/DeletionCard/DeletionCard.tsx

+  isPersonalSettings: boolean
+}
+
+function EraseSection({ isPersonalSettings }: EraseSectionProps) {


What is the difference between this and the other DeletionCard component in the profile tab? Do we want to update that too?

Hrmrmrm profile tab is self hosted only or DEC, let me go ask in the ticket.

They wanted it on both

nsdeschenes added 3 commits May 23, 2024 08:41

remove ErasePersonalAccountButton

b4ebd81

update messaging and convert to TS

015cd6d

Update tests

cd3024c

rohitvinnakota-codecov reviewed May 24, 2024

View reviewed changes

nsdeschenes added 4 commits May 28, 2024 13:57

remove ErasePersonalAccountButton component

eaa1381

update to TS and remove ErasePersonalAccountButton

a045a80

update use in Profile.jsx

c16c0f6

remove redundent test

aa75d9b

rohitvinnakota-codecov approved these changes May 28, 2024

View reviewed changes

Merge branch 'main' into gh-int-388-update-delete-account-messaging

15c7708

nicholas-codecov added this pull request to the merge queue Jun 3, 2024

Merged via the queue into main with commit dd56fc4 Jun 3, 2024

nicholas-codecov deleted the gh-int-388-update-delete-account-messaging branch June 3, 2024 14:17

This was referenced Feb 14, 2025

Unify and slightly reword account deletion #3742

Merged

Reintroduce the "delete account" action #3745

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: Update delete account messaging#2892

ref: Update delete account messaging#2892
nicholas-codecov merged 8 commits intomainfrom
gh-int-388-update-delete-account-messaging

nicholas-codecov commented May 23, 2024

Uh oh!

codecov-qa bot commented May 23, 2024 •

edited

Loading

Uh oh!

codecov-notifications bot commented May 23, 2024 •

edited

Loading

Uh oh!

codecov-public-qa bot commented May 23, 2024 •

edited

Loading

Uh oh!

codecov bot commented May 23, 2024 •

edited

Loading

Uh oh!

codecov-staging bot commented May 23, 2024 •

edited

Loading

Uh oh!

codecov bot commented May 23, 2024 •

edited

Loading

Uh oh!

codecov-releaser commented May 23, 2024 •

edited

Loading

Uh oh!

rohitvinnakota-codecov May 24, 2024

Uh oh!

nicholas-codecov May 24, 2024 •

edited

Loading

Uh oh!

nicholas-codecov Jun 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nicholas-codecov commented May 23, 2024

Description

Notable Changes

Screenshots

Uh oh!

codecov-qa bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-notifications bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-public-qa bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-staging bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

codecov bot commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

codecov-releaser commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy preview for gazebo ready!

Uh oh!

rohitvinnakota-codecov May 24, 2024

Choose a reason for hiding this comment

Uh oh!

nicholas-codecov May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicholas-codecov Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-qa bot commented May 23, 2024 •

edited

Loading

codecov-notifications bot commented May 23, 2024 •

edited

Loading

codecov-public-qa bot commented May 23, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading

codecov-staging bot commented May 23, 2024 •

edited

Loading

codecov bot commented May 23, 2024 •

edited

Loading

codecov-releaser commented May 23, 2024 •

edited

Loading

nicholas-codecov May 24, 2024 •

edited

Loading